Skip to content

chore(ci): run lint and test jobs on master#3198

Merged
oliverlaz merged 1 commit into
masterfrom
ci/run-lint-test-on-master
May 27, 2026
Merged

chore(ci): run lint and test jobs on master#3198
oliverlaz merged 1 commit into
masterfrom
ci/run-lint-test-on-master

Conversation

@oliverlaz
Copy link
Copy Markdown
Member

🎯 Goal

Previously the lint and test jobs were skipped on master (they only ran on pull requests), so anything reaching master outside the normal PR flow had no lint/test validation. Running them on master pushes adds a safety net.

🛠 Implementation details

Removed the if: ${{ github.ref_name != 'master' }} condition from the lint and test jobs in .github/workflows/ci.yml. Both jobs now run on every trigger (pull requests and pushes to master). The build job already ran unconditionally.

🎨 UI Changes

N/A — CI configuration only.

Remove the `github.ref_name \!= 'master'` guards from the lint and test
jobs so they also run on pushes to master, not only on pull requests.
@github-actions
Copy link
Copy Markdown

Size Change: +7 B (0%)

Total Size: 651 kB

📦 View Changed
Filename Size Change
dist/es/emojis.mjs 2.46 kB +2 B (+0.08%)
dist/es/index.mjs 253 kB +1 B (0%)
dist/es/useNotificationApi.mjs 44.9 kB +4 B (+0.01%)
ℹ️ View Unchanged
Filename Size
dist/cjs/audioProcessing.js 1.74 kB
dist/cjs/emojis.js 2.53 kB
dist/cjs/index.js 256 kB
dist/cjs/mp3-encoder.js 814 B
dist/cjs/useNotificationApi.js 46.2 kB
dist/css/emoji-picker.css 178 B
dist/css/emoji-replacement.css 456 B
dist/css/index.css 39.7 kB
dist/es/audioProcessing.mjs 1.65 kB
dist/es/mp3-encoder.mjs 768 B

compressed-size-action

@oliverlaz oliverlaz merged commit ce4352d into master May 27, 2026
7 checks passed
@oliverlaz oliverlaz deleted the ci/run-lint-test-on-master branch May 27, 2026 09:15
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.73%. Comparing base (20e554a) to head (cfedea1).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3198      +/-   ##
==========================================
+ Coverage   83.68%   83.73%   +0.04%     
==========================================
  Files         435      435              
  Lines       13028    13127      +99     
  Branches     4202     4249      +47     
==========================================
+ Hits        10903    10992      +89     
- Misses       2125     2135      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants